Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change structure of pmtilesRules, allow icon sheet, require returned promise. #1015

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

prushforth
Copy link
Member

@prushforth prushforth commented Nov 14, 2024

Closes #1011

Remove grunt-rollup grunt plugin, replace with customRollup task,
config done via external rollup.config.js.

Remove uglify grunt plugin, replace with terser rollup plugin (does a
better job with source maps and chained minification)

Add nrcan-basemap grunt task for sibling project to get nrcan vector
tile basemap working with pmtiles.

Change the required structure of pmtilesRules.js - requires a sheet
that gets loaded via sheet.load(), after which all the style rules are
set and returned.  This allows style label rules to use IconSymbolizers,
however it requires a slightly awkward structure to be imposed on
a pmtiles stylesheet module.  See pmtilesRules.js, and corresponding
test stylesheet modules for more info.

Add await on loading the pmtilesRules.js stylesheet module

Add script 'test-serve' to package.json to run the test web server to debug test
HTML pages as required, removing the need to drop into a console

Update pmtiles test that was not testing rendering, only a blank map
canvas.

Add test mvt tiles to validate that protomapsL is available to stylesheet
modules upon import.

Add test for custom styled mvt data, with win32 capture only

Restructure test style modules to conform to new promise-returning
expected structure

Adjuust timeout limit on map-link whenReady()

Conditionally await on map-link.whenReady() for stylesheet module
associated to pmtiles / mvt layer (if omitted, don't want exceptions,
prefer to reject in whenReady(), although it's slow.

Add linux image for custom styles.  Loosen pixel comparison to 200 pixels
Remove postinstall --with-deps so that npm install does not require
root privilege
@prushforth prushforth marked this pull request as ready for review November 15, 2024 22:07
@prushforth prushforth merged commit ddba5df into Maps4HTML:main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pmtilesRules fails with missing protomapsL global variable
1 participant